From: Pavel Begunkov <asml.silence@gmail.com>
Date: Tue, 18 Oct 2022 19:50:55 +0000 (+0100)
Subject: bio: safeguard REQ_ALLOC_CACHE bio put
X-Git-Tag: v6.0.8~107
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=48629bf2ec08cc5c0aa87a8437f9d30b3673d112;p=thirdparty%2Fkernel%2Fstable.git

bio: safeguard REQ_ALLOC_CACHE bio put

[ Upstream commit d4347d50407daea6237872281ece64c4bdf1ec99 ]

bio_put() with REQ_ALLOC_CACHE assumes that it's executed not from
an irq context. Let's add a warning if the invariant is not respected,
especially since there is a couple of places removing REQ_POLLED by hand
without also clearing REQ_ALLOC_CACHE.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/558d78313476c4e9c233902efa0092644c3d420a.1666122465.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/block/bio.c b/block/bio.c
index 77e3b764a0784..fc2364cf17750 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -741,7 +741,7 @@ void bio_put(struct bio *bio)
 			return;
 	}
 
-	if (bio->bi_opf & REQ_ALLOC_CACHE) {
+	if ((bio->bi_opf & REQ_ALLOC_CACHE) && !WARN_ON_ONCE(in_interrupt())) {
 		struct bio_alloc_cache *cache;
 
 		bio_uninit(bio);