From: Greg Kroah-Hartman Date: Sat, 28 Jun 2014 15:37:35 +0000 (-0400) Subject: 3.4-stable patches X-Git-Tag: v3.4.96~10 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=486678e4f0ceef6f1e1cff26e3ddcc0f0b438050;p=thirdparty%2Fkernel%2Fstable-queue.git 3.4-stable patches added patches: usb-usbtest-add-timetout-to-simple_io.patch --- diff --git a/queue-3.4/series b/queue-3.4/series index f117b44eaf3..f1e6e788962 100644 --- a/queue-3.4/series +++ b/queue-3.4/series @@ -39,3 +39,4 @@ btrfs-fix-double-free-in-find_lock_delalloc_range.patch fs-btrfs-volumes.c-fix-for-possible-null-pointer-dereference.patch btrfs-use-right-type-to-get-real-comparison.patch btrfs-fix-use-of-uninit-ret-in-end_extent_writepage.patch +usb-usbtest-add-timetout-to-simple_io.patch diff --git a/queue-3.4/usb-usbtest-add-timetout-to-simple_io.patch b/queue-3.4/usb-usbtest-add-timetout-to-simple_io.patch new file mode 100644 index 00000000000..6df9ec59f58 --- /dev/null +++ b/queue-3.4/usb-usbtest-add-timetout-to-simple_io.patch @@ -0,0 +1,56 @@ +From e5e4746510d140261918aecce2e5e3aa4456f7e9 Mon Sep 17 00:00:00 2001 +From: Roger Quadros +Date: Wed, 18 Dec 2013 15:40:10 +0530 +Subject: usb: usbtest: Add timetout to simple_io() + +From: Roger Quadros + +commit e5e4746510d140261918aecce2e5e3aa4456f7e9 upstream. + +Without a timetout some tests e.g. test_halt() can remain stuck forever. + +Signed-off-by: Roger Quadros +Reviewed-by: Felipe Balbi +Signed-off-by: Greg Kroah-Hartman + +--- + drivers/usb/misc/usbtest.c | 14 +++++++++++--- + 1 file changed, 11 insertions(+), 3 deletions(-) + +--- a/drivers/usb/misc/usbtest.c ++++ b/drivers/usb/misc/usbtest.c +@@ -10,6 +10,7 @@ + #include + #include + ++#define SIMPLE_IO_TIMEOUT 10000 /* in milliseconds */ + + /*-------------------------------------------------------------------------*/ + +@@ -355,6 +356,7 @@ static int simple_io( + int max = urb->transfer_buffer_length; + struct completion completion; + int retval = 0; ++ unsigned long expire; + + urb->context = &completion; + while (retval == 0 && iterations-- > 0) { +@@ -367,9 +369,15 @@ static int simple_io( + if (retval != 0) + break; + +- /* NOTE: no timeouts; can't be broken out of by interrupt */ +- wait_for_completion(&completion); +- retval = urb->status; ++ expire = msecs_to_jiffies(SIMPLE_IO_TIMEOUT); ++ if (!wait_for_completion_timeout(&completion, expire)) { ++ usb_kill_urb(urb); ++ retval = (urb->status == -ENOENT ? ++ -ETIMEDOUT : urb->status); ++ } else { ++ retval = urb->status; ++ } ++ + urb->dev = udev; + if (retval == 0 && usb_pipein(urb->pipe)) + retval = simple_check_buf(tdev, urb);