From: Mukund Sivaraman Date: Tue, 15 Jan 2013 08:00:37 +0000 (+0530) Subject: [2435] Add a note that some records may not be found by the datasrc RRsetCollection X-Git-Tag: bind10-1.0.0-rc-release~102 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=48892724360a9c706de8c2ffaa5099dc1da211ea;p=thirdparty%2Fkea.git [2435] Add a note that some records may not be found by the datasrc RRsetCollection --- diff --git a/src/lib/datasrc/rrset_collection_base.h b/src/lib/datasrc/rrset_collection_base.h index 7a414df762..c02df9a055 100644 --- a/src/lib/datasrc/rrset_collection_base.h +++ b/src/lib/datasrc/rrset_collection_base.h @@ -56,6 +56,10 @@ public: /// given \c name, \c rrclass and \c rrtype. If no matching RRset /// is found, \c NULL is returned. /// + /// Note that not all records added through the updater may + /// necessarily be found by this method, such as RRs subject to + /// DNAME substitution. + /// /// \throw isc::dns::RRsetCollectionError if \c find() results in /// some underlying datasrc error, or if \c disable() was called. /// diff --git a/src/lib/datasrc/tests/database_unittest.cc b/src/lib/datasrc/tests/database_unittest.cc index 0ca5a02dc9..94d90b5e3b 100644 --- a/src/lib/datasrc/tests/database_unittest.cc +++ b/src/lib/datasrc/tests/database_unittest.cc @@ -4234,12 +4234,11 @@ TYPED_TEST(RRsetCollectionTest, find) { this->qclass_, RRType::AAAA()); EXPECT_FALSE(rrset); - // TODO: "below.dname.example.org." with type A does not return the - // record (see top of file). It needs to be checked if this is what - // we want. + // "below.dname.example.org." with type A does not return the record + // (see top of file). See \c isc::datasrc::RRsetCollectionBase::find() + // documentation for details. rrset = this->collection.find(Name("below.dname.example.org"), this->qclass_, RRType::A()); - // Is this correct behavior? EXPECT_FALSE(rrset); // With the FIND_GLUE_OK option passed to ZoneFinder's find(),