From: Felix Fietkau <nbd@nbd.name>
Date: Sat, 27 Apr 2024 18:24:18 +0000 (+0200)
Subject: net: bridge: fix multicast-to-unicast with fraglist GSO
X-Git-Tag: v5.10.217~75
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=48ab384d2bc65b824bb98a640d9eee6a091dd71a;p=thirdparty%2Fkernel%2Fstable.git

net: bridge: fix multicast-to-unicast with fraglist GSO

[ Upstream commit 59c878cbcdd80ed39315573b3511d0acfd3501b5 ]

Calling skb_copy on a SKB_GSO_FRAGLIST skb is not valid, since it returns
an invalid linearized skb. This code only needs to change the ethernet
header, so pskb_copy is the right function to call here.

Fixes: 6db6f0eae605 ("bridge: multicast to unicast")
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c
index f2ef75c7ccc68..3a70682e63524 100644
--- a/net/bridge/br_forward.c
+++ b/net/bridge/br_forward.c
@@ -253,7 +253,7 @@ static void maybe_deliver_addr(struct net_bridge_port *p, struct sk_buff *skb,
 	if (skb->dev == p->dev && ether_addr_equal(src, addr))
 		return;
 
-	skb = skb_copy(skb, GFP_ATOMIC);
+	skb = pskb_copy(skb, GFP_ATOMIC);
 	if (!skb) {
 		DEV_STATS_INC(dev, tx_dropped);
 		return;