From: lekma <lekmalek@gmail.com>
Date: Wed, 2 May 2018 09:29:10 +0000 (+0200)
Subject: bpo-33391: Fix refleak in set_symmetric_difference (GH-6670)
X-Git-Tag: v3.8.0a1~1892
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=491bbedc209fea314a04cb3015da68fb0aa63238;p=thirdparty%2FPython%2Fcpython.git

bpo-33391: Fix refleak in set_symmetric_difference (GH-6670)
---

diff --git a/Misc/NEWS.d/next/Core and Builtins/2018-05-02-08-36-03.bpo-33391.z4a7rb.rst b/Misc/NEWS.d/next/Core and Builtins/2018-05-02-08-36-03.bpo-33391.z4a7rb.rst
new file mode 100644
index 000000000000..ab17aa408c06
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2018-05-02-08-36-03.bpo-33391.z4a7rb.rst	
@@ -0,0 +1 @@
+Fix a leak in set_symmetric_difference().
diff --git a/Objects/setobject.c b/Objects/setobject.c
index 80101dda9bee..82b583820816 100644
--- a/Objects/setobject.c
+++ b/Objects/setobject.c
@@ -1744,8 +1744,10 @@ set_symmetric_difference(PySetObject *so, PyObject *other)
     if (otherset == NULL)
         return NULL;
     rv = set_symmetric_difference_update(otherset, (PyObject *)so);
-    if (rv == NULL)
+    if (rv == NULL) {
+        Py_DECREF(otherset);
         return NULL;
+    }
     Py_DECREF(rv);
     return (PyObject *)otherset;
 }