From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 9 Nov 2020 13:49:26 +0000 (-0500)
Subject: don't run icmp on Linux.  it requires root or setcap
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=495e95bd2ece7101443fa2d9be985c09a71398d6;p=thirdparty%2Ffreeradius-server.git

don't run icmp on Linux.  it requires root or setcap
---

diff --git a/src/tests/modules/all.mk b/src/tests/modules/all.mk
index 3e4589b0a98..c1c990ddcfa 100644
--- a/src/tests/modules/all.mk
+++ b/src/tests/modules/all.mk
@@ -14,8 +14,16 @@ FILES := $(sort $(patsubst $(DIR)/%.unlang,%,$(call FIND_FILES_SUFFIX,$(DIR),*.u
 #  Remove things which are known to fail on travis.
 #  Or which are known to have long runtimes 
 #
+#  Also don't run icmp tests on Linux, they require setcap, or root.
+#  @todo - on Linux, *check* for root, or use "getcap" to see if the
+#  unit_test_module binary has the correct permissions.
+#
 ifeq "$(TRAVIS)" "1"
   FILES_SKIP := $(filter icmp/%,$(FILES))
+
+else ifeq "$(findstring apple,$(AC_HOSTINFO))" ""
+  FILES_SKIP := $(filter icmp/%,$(FILES))
+
 else ifneq "$(RUN_SLOW_TESTS)" "1"
   FILES_SKIP += $(filter imap/%,$(FILES))
 endif