From: GeoSot <geo.sotis@gmail.com>
Date: Wed, 9 Jun 2021 22:10:14 +0000 (+0300)
Subject: Remove redundant check on `data-toggle` click.
X-Git-Tag: v5.1.0~32
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4961ad0c63849d360edf7c23a15001ff56d58639;p=thirdparty%2Fbootstrap.git

Remove redundant check on `data-toggle` click.

Previously, it was assumed that the trigger element would have its own separate config than the collapse element itself.
---

diff --git a/js/src/collapse.js b/js/src/collapse.js
index a8651fc0a9..fcb8be6d7d 100644
--- a/js/src/collapse.js
+++ b/js/src/collapse.js
@@ -347,26 +347,16 @@ EventHandler.on(document, EVENT_CLICK_DATA_API, SELECTOR_DATA_TOGGLE, function (
     event.preventDefault()
   }
 
-  const triggerData = Manipulator.getDataAttributes(this)
   const selector = getSelectorFromElement(this)
   const selectorElements = SelectorEngine.find(selector)
 
   selectorElements.forEach(element => {
     const data = Collapse.getInstance(element)
-    let config
     if (data) {
-      // update parent attribute
-      if (data._parent === null && typeof triggerData.parent === 'string') {
-        data._config.parent = triggerData.parent
-        data._parent = data._getParent()
-      }
-
-      config = 'toggle'
+      data.toggle()
     } else {
-      config = triggerData
+      Collapse.getOrCreateInstance(element)
     }
-
-    Collapse.collapseInterface(element, config)
   })
 })