From: Marcin Wojtas Date: Mon, 30 Nov 2015 12:27:43 +0000 (+0100) Subject: net: mvneta: fix bit assignment for RX packet irq enable X-Git-Tag: v3.16.35~826 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=49b4d2ca1693a6c3fd94ad3aab14160fb9002ede;p=thirdparty%2Fkernel%2Fstable.git net: mvneta: fix bit assignment for RX packet irq enable commit dc1aadf6f1e7609590fadf7a0252413732289b2e upstream. A value originally defined in the driver was inappropriate. Even though the ingress was somehow working, writing MVNETA_RXQ_INTR_ENABLE_ALL_MASK to MVNETA_INTR_ENABLE didn't make any effect, because the bits [31:16] are reserved and read-only. This commit updates MVNETA_RXQ_INTR_ENABLE_ALL_MASK to be compliant with the controller's documentation. Signed-off-by: Marcin Wojtas Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network unit") Signed-off-by: David S. Miller Signed-off-by: Luis Henriques --- diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 798f9c78a83f9..0830d23f01ae7 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -153,7 +153,7 @@ #define MVNETA_INTR_ENABLE 0x25b8 #define MVNETA_TXQ_INTR_ENABLE_ALL_MASK 0x0000ff00 -#define MVNETA_RXQ_INTR_ENABLE_ALL_MASK 0xff000000 // note: neta says it's 0x000000FF +#define MVNETA_RXQ_INTR_ENABLE_ALL_MASK 0x000000ff #define MVNETA_RXQ_CMD 0x2680 #define MVNETA_RXQ_DISABLE_SHIFT 8