From: Pavel Filipenský <pfilipensky@samba.org>
Date: Thu, 21 Dec 2023 12:57:38 +0000 (+0100)
Subject: s3:ads: Do not update system keytab from "net ads changetrustpw"
X-Git-Tag: tdb-1.4.11~31
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=49d09906890dbd864de155cfdb90e96527fc478e;p=thirdparty%2Fsamba.git

s3:ads: Do not update system keytab from "net ads changetrustpw"

It will be done in secrets_{prepare,finish}_password_change

BUG: https://bugzilla.samba.org/show_bug.cgi?id=6750

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/utils/net_ads.c b/source3/utils/net_ads.c
index 9f0dbf0611e..5adb0a7a6be 100644
--- a/source3/utils/net_ads.c
+++ b/source3/utils/net_ads.c
@@ -2691,13 +2691,6 @@ int net_ads_changetrustpw(struct net_context *c, int argc, const char **argv)
 
 	d_printf(_("Password change for principal %s succeeded.\n"), host_principal);
 
-	if (USE_SYSTEM_KEYTAB) {
-		d_printf(_("Attempting to update system keytab with new password.\n"));
-		if (ads_keytab_create_default(ads)) {
-			d_printf(_("Failed to update system keytab.\n"));
-		}
-	}
-
 	ret = 0;
 out:
 	TALLOC_FREE(tmp_ctx);