From: Bart Van Assche <bvanassche@acm.org>
Date: Thu, 28 Feb 2008 20:27:34 +0000 (+0000)
Subject: Removed calls to set_thread_name() because the calls to snprintf() caused data races.
X-Git-Tag: svn/VALGRIND_3_4_0~1008
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4a4130c96f0a4263585e0e0f5bea6ece255575a4;p=thirdparty%2Fvalgrind.git

Removed calls to set_thread_name() because the calls to snprintf() caused data races.

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7503
---

diff --git a/exp-drd/tests/pth_detached.c b/exp-drd/tests/pth_detached.c
index 1d61aa11a3..5f20a250ad 100644
--- a/exp-drd/tests/pth_detached.c
+++ b/exp-drd/tests/pth_detached.c
@@ -12,16 +12,6 @@
 static int s_finished_count;
 static pthread_mutex_t s_mutex;
 
-static void set_thread_name(const char* const fmt, const int arg)
-{
-  int res;
-  char name[32];
-  snprintf(name, sizeof(name), fmt, arg);
-  name[sizeof(name) - 1] = 0;
-  VALGRIND_DO_CLIENT_REQUEST(res, 0, VG_USERREQ__SET_THREAD_NAME,
-                             name, 0, 0, 0, 0);
-}
-
 void increment_finished_count()
 {
   pthread_mutex_lock(&s_mutex);
@@ -40,7 +30,6 @@ int get_finished_count()
 
 static void* thread_func1(void* arg)
 {
-  set_thread_name("thread_func1[%d]", *(int*)arg);
   write(STDOUT_FILENO, ".", 1);
   increment_finished_count();
   return 0;
@@ -48,7 +37,6 @@ static void* thread_func1(void* arg)
 
 static void* thread_func2(void* arg)
 {
-  set_thread_name("thread_func2[%d]", *(int*)arg);
   pthread_detach(pthread_self());
   write(STDOUT_FILENO, ".", 1);
   increment_finished_count();
@@ -64,8 +52,6 @@ int main(int argc, char** argv)
   int detachstate;
   pthread_attr_t attr;
 
-  set_thread_name("main", 0);
-
   for (i = 0; i < count1 || i < count2; i++)
     thread_arg[i] = i;