From: Andrew Bartlett Date: Wed, 15 May 2019 02:47:53 +0000 (+1200) Subject: s4 dsdb/repl_meta_data: allocate new extended DNs during ADD on a better context X-Git-Tag: tdb-1.4.1~35 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4aa9924310287ff3b36618496fa6c707c615ad4c;p=thirdparty%2Fsamba.git s4 dsdb/repl_meta_data: allocate new extended DNs during ADD on a better context Lower down in this function new_values is assigned over el->values and is filled in with the values of all the parsed DNs. Therefore it is the natural talloc parent. This will allow el->values to be allocated on tmp_ctx in the next commit for a working area during the function call. Signed-off-by: Andrew Bartlett Reviewed-by: Douglas Bagnall --- diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c index e68a376a79e..6c65820e84e 100644 --- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c +++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c @@ -1052,7 +1052,7 @@ static int replmd_add_fix_la(struct ldb_module *module, TALLOC_CTX *mem_ctx, for (i = 0; i < el->num_values; i++) { struct parsed_dn *p = &pdn[i]; - ret = replmd_build_la_val(el->values, p->v, p->dsdb_dn, + ret = replmd_build_la_val(new_values, p->v, p->dsdb_dn, &ac->our_invocation_id, ac->seq_num, now); if (ret != LDB_SUCCESS) {