From: Michael Tremer <michael.tremer@ipfire.org>
Date: Sat, 24 Jan 2026 15:25:23 +0000 (+0000)
Subject: dbl: Allow to preselect the block/allow option
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4abb81f4ccce60e3bb4ad7dd19476990aa4b052a;p=ipfire.org.git

dbl: Allow to preselect the block/allow option

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/templates/dbl/reports/submit.html b/src/templates/dbl/reports/submit.html
index 9040b1c7..44a0ffb2 100644
--- a/src/templates/dbl/reports/submit.html
+++ b/src/templates/dbl/reports/submit.html
@@ -99,11 +99,11 @@
 								<div class="control">
 									<div class="select is-fullwidth">
 										<select name="block" required>
-											<option value="yes">
+											<option value="yes" {% if block %}selected{% end %}>
 												{{ _("This domain should be blocked, but isn't") }}
 											</option>
 
-											<option value="no">
+											<option value="no" {% if not block %}selected{% end %}>
 												{{ _("This domain should not be blocked, but currently is") }}
 											</option>
 										</select>
diff --git a/src/web/dbl.py b/src/web/dbl.py
index 10f3b16e..15ee0cac 100644
--- a/src/web/dbl.py
+++ b/src/web/dbl.py
@@ -102,8 +102,12 @@ class SubmitReportHandler(base.AnalyticsMixin, BaseHandler):
 		# Fetch any pre-selected names
 		name = self.get_argument("name", None)
 
+		# Block or not?
+		block = self.get_argument_bool("block")
+
 		# Render the page
-		self.render("dbl/reports/submit.html", lists=lists, list=list, name=name)
+		self.render("dbl/reports/submit.html",
+			lists=lists, list=list, name=name, block=block)
 
 	@tornado.web.authenticated
 	@base.ratelimit(minutes=60, requests=10)
@@ -116,7 +120,7 @@ class SubmitReportHandler(base.AnalyticsMixin, BaseHandler):
 			name        = self.get_argument("name"),
 			reported_by = self.current_user,
 			comment     = self.get_argument("comment", ""),
-			block       = self.get_argument("block", "off") == "on",
+			block       = self.get_argument_bool("block"),
 		)
 
 		# Render a result page