From: Jeremy Allison <jra@samba.org>
Date: Tue, 5 Jun 2012 00:34:54 +0000 (-0700)
Subject: Fix bug #8972 - Directory group write permission bit is set if unix extensions are... 
X-Git-Tag: samba-4.0.0beta1~24
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4accd2396e8a9ac4a7b2191a1d3bc9c84d2e0497;p=thirdparty%2Fsamba.git

Fix bug #8972 - Directory group write permission bit is set if unix extensions are enabled

We can't manipulate file_attributes if it's a posix call. I'll look
at adding a test for this asap.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Jun  5 04:26:11 CEST 2012 on sn-devel-104
---

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 17721c61270..a012675f566 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -2714,8 +2714,10 @@ static NTSTATUS open_directory(connection_struct *conn,
 		return NT_STATUS_NOT_A_DIRECTORY;
 	}
 
-	/* Ensure we have a directory attribute. */
-	file_attributes |= FILE_ATTRIBUTE_DIRECTORY;
+	if (!(file_attributes & FILE_FLAG_POSIX_SEMANTICS)) {
+		/* Ensure we have a directory attribute. */
+		file_attributes |= FILE_ATTRIBUTE_DIRECTORY;
+	}
 
 	DEBUG(5,("open_directory: opening directory %s, access_mask = 0x%x, "
 		 "share_access = 0x%x create_options = 0x%x, "