From: Volker Lendecke <vl@samba.org>
Date: Tue, 15 Feb 2011 17:16:43 +0000 (+0100)
Subject: s3-amend: Don't overwrite existing values
X-Git-Tag: tevent-0.9.11~650
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4b354e67fc7adce5152c73697bbf02a1aac69b20;p=thirdparty%2Fsamba.git

s3-amend: Don't overwrite existing values

This saves a ton of tdb transactions on smbd startup

Andreas, Günther, please check!

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Feb 15 19:11:25 CET 2011 on sn-devel-104
---

diff --git a/source3/registry/reg_api.c b/source3/registry/reg_api.c
index acce7ab1b47..7c2e01dccc5 100644
--- a/source3/registry/reg_api.c
+++ b/source3/registry/reg_api.c
@@ -659,6 +659,7 @@ done:
 WERROR reg_setvalue(struct registry_key *key, const char *name,
 		    const struct registry_value *val)
 {
+	struct regval_blob *existing;
 	WERROR err;
 	int res;
 
@@ -670,6 +671,15 @@ WERROR reg_setvalue(struct registry_key *key, const char *name,
 		return err;
 	}
 
+	existing = regval_ctr_getvalue(key->values, name);
+
+	if ((existing != NULL) &&
+	    (regval_size(existing) == val->data.length) &&
+	    (memcmp(regval_data_p(existing), val->data.data,
+		    val->data.length) == 0)) {
+		return WERR_OK;
+	}
+
 	res = regval_ctr_addvalue(key->values, name, val->type,
 				  val->data.data, val->data.length);