From: Serhiy Storchaka <storchaka@gmail.com>
Date: Tue, 21 Jan 2025 14:45:20 +0000 (+0200)
Subject: gh-71339: Fix an order-dependent failure in test_unittest (GH-129133)
X-Git-Tag: v3.14.0a5~314
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4b37a6bda236121c130b4a60e573f123cb5e4c58;p=thirdparty%2FPython%2Fcpython.git

gh-71339: Fix an order-dependent failure in test_unittest (GH-129133)

It failed if it was preceded by test_builtin.
---

diff --git a/Lib/test/test_builtin.py b/Lib/test/test_builtin.py
index 73b139e405ae..913d007a126d 100644
--- a/Lib/test/test_builtin.py
+++ b/Lib/test/test_builtin.py
@@ -1833,7 +1833,10 @@ class BuiltinTest(ComplexesAreIdenticalMixin, unittest.TestCase):
 
     def test_setattr(self):
         setattr(sys, 'spam', 1)
-        self.assertEqual(sys.spam, 1)
+        try:
+            self.assertEqual(sys.spam, 1)
+        finally:
+            del sys.spam
         self.assertRaises(TypeError, setattr)
         self.assertRaises(TypeError, setattr, sys)
         self.assertRaises(TypeError, setattr, sys, 'spam')
diff --git a/Lib/test/test_unittest/test_case.py b/Lib/test/test_unittest/test_case.py
index df1381451b7e..a04af55f3fc0 100644
--- a/Lib/test/test_unittest/test_case.py
+++ b/Lib/test/test_unittest/test_case.py
@@ -801,9 +801,9 @@ class Test_TestCase(unittest.TestCase, TestEquality, TestHashing):
         self.assertEqual(str(cm.exception),
                 "type object 'List' has no attribute 'spam'")
         with self.assertRaises(self.failureException) as cm:
-            self.assertHasAttr(sys, 'spam')
+            self.assertHasAttr(sys, 'nonexistent')
         self.assertEqual(str(cm.exception),
-                "module 'sys' has no attribute 'spam'")
+                "module 'sys' has no attribute 'nonexistent'")
 
         with self.assertRaises(self.failureException) as cm:
             self.assertHasAttr(a, 'y', 'ababahalamaha')