From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Sun, 17 Dec 2023 20:31:11 +0000 (+1300)
Subject: s3:utils: Do not pass invalid file descriptor to close() (CID 1550131)
X-Git-Tag: talloc-2.4.2~214
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4b39a3e77537715e8fd79b6014b97183a0a60cdb;p=thirdparty%2Fsamba.git

s3:utils: Do not pass invalid file descriptor to close() (CID 1550131)

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/utils/smbcacls.c b/source3/utils/smbcacls.c
index c9ae501d172..ff11ba4d7d7 100644
--- a/source3/utils/smbcacls.c
+++ b/source3/utils/smbcacls.c
@@ -2028,7 +2028,7 @@ static int cacl_dump_dacl(struct cli_state *cli,
 		dump_ctx->stats->success, dump_ctx->stats->failure);
 	result = EXIT_OK;
 out:
-	if (dump_ctx && dump_ctx->save_fd) {
+	if (dump_ctx && dump_ctx->save_fd > 0) {
 		close(dump_ctx->save_fd);
 	}
 	TALLOC_FREE(ctx);