From: Taehee Yoo <ap420073@gmail.com>
Date: Mon, 23 May 2022 16:17:08 +0000 (+0000)
Subject: amt: fix possible memory leak in amt_rcv()
X-Git-Tag: v5.18.4~257
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4b8032d39b276c52db57ff834c300405b9da2691;p=thirdparty%2Fkernel%2Fstable.git

amt: fix possible memory leak in amt_rcv()

[ Upstream commit 1a1a0e80e005cbdc2c250fc858e1d8570f4e4acb ]

If an amt receives packets and it finds socket.
If it can't find a socket, it should free a received skb.
But it doesn't.
So, a memory leak would possibly occur.

Fixes: cbc21dc1cfe9 ("amt: add data plane of amt interface")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/net/amt.c b/drivers/net/amt.c
index d376ed89f836c..22d7da749a240 100644
--- a/drivers/net/amt.c
+++ b/drivers/net/amt.c
@@ -2679,7 +2679,7 @@ static int amt_rcv(struct sock *sk, struct sk_buff *skb)
 	amt = rcu_dereference_sk_user_data(sk);
 	if (!amt) {
 		err = true;
-		goto out;
+		goto drop;
 	}
 
 	skb->dev = amt->dev;