From: Günther Deschner <gd@samba.org>
Date: Tue, 21 Sep 2004 10:40:45 +0000 (+0000)
Subject: r2472: Fixed krb5_krbhost_get_addrinfo()-parameters and make failure
X-Git-Tag: samba-misc-tags/initial-v3-0-unstable~5781
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4bd9d8240b571fdd8546af4eea3f4f148987d57c;p=thirdparty%2Fsamba.git

r2472: Fixed krb5_krbhost_get_addrinfo()-parameters and make failure
of this call non-critical.

Thanks to Love for the patch and explaining the inner workings of
heimdal.

Guenther
---

diff --git a/source/libsmb/clikrb5.c b/source/libsmb/clikrb5.c
index de2f0cec18a..2b0c0544937 100644
--- a/source/libsmb/clikrb5.c
+++ b/source/libsmb/clikrb5.c
@@ -190,7 +190,7 @@
 	krb5_error_code rc;
 	int num_kdcs, i;
 	struct sockaddr *sa;
-	struct addrinfo **ai;
+	struct addrinfo *ai;
 
 	*addr_pp = NULL;
 	*naddrs = 0;
@@ -226,10 +226,10 @@
 	for (i = 0; i < num_kdcs && (rc = krb5_krbhst_next(ctx, hnd, &hinfo) == 0); i++) {
 
 #if defined(HAVE_KRB5_KRBHST_GET_ADDRINFO)
-		rc = krb5_krbhst_get_addrinfo(ctx, hinfo, ai);
+		rc = krb5_krbhst_get_addrinfo(ctx, hinfo, &ai);
 		if (rc) {
 			DEBUG(0,("krb5_krbhst_get_addrinfo failed: %s\n", error_message(rc)));
-			return rc;
+			continue;
 		}
 #endif
 		if (hinfo->ai && hinfo->ai->ai_family == AF_INET)