From: Mark Andrews <marka@isc.org>
Date: Tue, 11 Jul 2023 08:40:10 +0000 (+1000)
Subject: Address potential memory leak in dst__openssl_fromlabel
X-Git-Tag: v9.19.17~17^2~6
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4c4ecbc83c59d634517de5550c49cae28b0c0e6a;p=thirdparty%2Fbind9.git

Address potential memory leak in dst__openssl_fromlabel
---

diff --git a/lib/dns/openssl_link.c b/lib/dns/openssl_link.c
index c361c3083bb..424657b1b28 100644
--- a/lib/dns/openssl_link.c
+++ b/lib/dns/openssl_link.c
@@ -342,6 +342,16 @@ dst__openssl_fromlabel(int key_base_id, const char *engine, const char *label,
 							ppub, ppriv));
 	}
 
+	if (*ppub != NULL) {
+		EVP_PKEY_free(*ppub);
+		*ppub = NULL;
+	}
+
+	if (*ppriv != NULL) {
+		EVP_PKEY_free(*ppriv);
+		*ppriv = NULL;
+	}
+
 	return (dst__openssl_fromlabel_engine(key_base_id, engine, label, pin,
 					      ppub, ppriv));
 }