From: Eric Leblond <eric@regit.org>
Date: Wed, 26 Jun 2013 07:56:11 +0000 (+0200)
Subject: Coverity 1038106: fix FP out-of-bond access
X-Git-Tag: suricata-2.0beta1~87
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4c6595f4379eafe81f1232c4cf4306cdc1d3a793;p=thirdparty%2Fsuricata.git

Coverity 1038106: fix FP out-of-bond access

A cast during the reading of a configuration variable was invalid
because a 16 bit integer was cast to a 32 bit integer. The called
function is only setting the pointer value to 1 or 0 so there is
no real issue there.
---

diff --git a/src/runmode-af-packet.c b/src/runmode-af-packet.c
index bfaf832c1c..1c9d2ad3da 100644
--- a/src/runmode-af-packet.c
+++ b/src/runmode-af-packet.c
@@ -252,10 +252,11 @@ void *ParseAFPConfig(const char *iface)
         /* In hash mode, we also ask for defragmentation needed to
          * compute the hash */
         uint16_t defrag = 0;
+        int conf_val = 0;
         SCLogInfo("Using flow cluster mode for AF_PACKET (iface %s)",
                 aconf->iface);
-        ConfGetChildValueBoolWithDefault(if_root, if_default, "defrag", (int *)&defrag);
-        if (defrag) {
+        ConfGetChildValueBoolWithDefault(if_root, if_default, "defrag", &conf_val);
+        if (conf_val) {
             SCLogInfo("Using defrag kernel functionality for AF_PACKET (iface %s)",
                     aconf->iface);
             defrag = PACKET_FANOUT_FLAG_DEFRAG;