From: Vladimír Čunát <vladimir.cunat@nic.cz>
Date: Fri, 30 Nov 2018 13:57:30 +0000 (+0100)
Subject: nitpicks from lgtm.com
X-Git-Tag: v3.2.1~8^2~4
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4cde7a3014e4e8fcb181b8ed75acf90001f318f4;p=thirdparty%2Fknot-resolver.git

nitpicks from lgtm.com

The script has been unused for longer time.
Almost all remaining C warnings are just "FIXME" comments :-)
and I didn't touch the JS warnings.
---

diff --git a/daemon/main.c b/daemon/main.c
index eb1f1d53d..15c7c1cae 100644
--- a/daemon/main.c
+++ b/daemon/main.c
@@ -451,7 +451,7 @@ static int run_worker(uv_loop_t *loop, struct engine *engine, fd_array_t *ipc_se
 			pipe_ret = uv_pipe_open(&pipe, args->control_fd);
 		} else {
 			(void) mkdir("tty", S_IRWXU|S_IRWXG);
-			sock_file = afmt("tty/%ld", getpid());
+			sock_file = afmt("tty/%ld", (long)getpid());
 			if (sock_file) {
 				pipe_ret = uv_pipe_bind(&pipe, sock_file);
 			}
diff --git a/scripts/inet_pton.py b/scripts/inet_pton.py
deleted file mode 100755
index 6eea32ac2..000000000
--- a/scripts/inet_pton.py
+++ /dev/null
@@ -1,20 +0,0 @@
-#!/usr/bin/env python3
-"""
-Print IP address to binary representation in Python hex format \x12
-"""
-
-from socket import inet_pton, AF_INET6, AF_INET
-import sys
-from binascii import hexlify
-
-try:
-    arg = sys.argv[1]
-except:
-    sys.exit('Usage: inet_pton.py <IPv4 or IPv6 address>')
-
-if ':' in arg:
-    addr_type = AF_INET6
-else:
-    addr_type = AF_INET
-
-print(repr(inet_pton(addr_type, arg)).strip("'"))