From: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Date: Thu, 9 Oct 2025 04:09:40 +0000 (+1300)
Subject: s4:kdc: Don’t leak pub_keys.keys
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4dc12177c515e63036ebf87b87ff2ebcf2b65bc0;p=thirdparty%2Fsamba.git

s4:kdc: Don’t leak pub_keys.keys

Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source4/kdc/db-glue.c b/source4/kdc/db-glue.c
index 80915f2c99c..6bdce0f3363 100644
--- a/source4/kdc/db-glue.c
+++ b/source4/kdc/db-glue.c
@@ -1880,14 +1880,16 @@ static krb5_error_code get_key_trust_public_keys(TALLOC_CTX *mem_ctx,
 					goto pub_keys_oom;
 				}
 			} else {
-				pub_keys.keys = realloc_p(pub_keys.keys,
-							struct sdb_pub_key,
-							pub_keys.len + 1);
-				if (pub_keys.keys == NULL) {
+				struct sdb_pub_key *keys = realloc_p(
+					pub_keys.keys,
+					struct sdb_pub_key,
+					pub_keys.len + 1);
+				if (keys == NULL) {
 					SAFE_FREE(pub_key.exponent.data);
 					SAFE_FREE(pub_key.modulus.data);
 					goto pub_keys_oom;
 				}
+				pub_keys.keys = keys;
 			}
 			pub_keys.keys[pub_keys.len] = pub_key;
 			pub_keys.len++;