From: Franck Bui <fbui@suse.com>
Date: Wed, 9 Dec 2020 08:46:08 +0000 (+0100)
Subject: udev: link_update() should fail if the entry in symlink dir couldn't have been created
X-Git-Tag: v248-rc1~547
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4e1db59274c4b31ba5369270a489420245616eb4;p=thirdparty%2Fsystemd.git

udev: link_update() should fail if the entry in symlink dir couldn't have been created

Follow-up for 30f6dce62cb3a738b20253f2192270607c31b55b
---

diff --git a/src/udev/udev-node.c b/src/udev/udev-node.c
index bde18f756e4..2cc78c9e2f4 100644
--- a/src/udev/udev-node.c
+++ b/src/udev/udev-node.c
@@ -214,20 +214,23 @@ static int link_update(sd_device *dev, const char *slink, bool add) {
         if (!filename)
                 return log_oom();
 
-        if (!add && unlink(filename) == 0)
-                (void) rmdir(dirname);
-
-        if (add)
-                do {
+        if (!add) {
+                if (unlink(filename) == 0)
+                        (void) rmdir(dirname);
+        } else
+                for (;;) {
                         _cleanup_close_ int fd = -1;
 
                         r = mkdir_parents(filename, 0755);
                         if (!IN_SET(r, 0, -ENOENT))
-                                break;
+                                return r;
+
                         fd = open(filename, O_WRONLY|O_CREAT|O_CLOEXEC|O_TRUNC|O_NOFOLLOW, 0444);
-                        if (fd < 0)
-                                r = -errno;
-                } while (r == -ENOENT);
+                        if (fd >= 0)
+                                break;
+                        if (errno != ENOENT)
+                                return -errno;
+                }
 
         /* If the database entry is not written yet we will just do one iteration and possibly wrong symlink
          * will be fixed in the second invocation. */