From: Roger Dingledine <arma@torproject.org>
Date: Fri, 29 Aug 2008 09:06:18 +0000 (+0000)
Subject: remove a code path that should never happen (and if it did, we'd be
X-Git-Tag: tor-0.2.1.5-alpha~12
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4eab76f07407bff7555ca0f11be584c7f4dfd106;p=thirdparty%2Ftor.git

remove a code path that should never happen (and if it did, we'd be
complaining about an errno set from some arbitrary previous problem).


svn:r16684
---

diff --git a/src/common/util.c b/src/common/util.c
index 102220de80..701e1b8f94 100644
--- a/src/common/util.c
+++ b/src/common/util.c
@@ -1702,11 +1702,12 @@ write_chunks_to_file_impl(const char *fname, const smartlist_t *chunks,
   SMARTLIST_FOREACH(chunks, sized_chunk_t *, chunk,
   {
     result = write_all(fd, chunk->bytes, chunk->len, 0);
-    if (result < 0 || (size_t)result != chunk->len) {
+    if (result < 0) {
       log(LOG_WARN, LD_FS, "Error writing to \"%s\": %s", fname,
           strerror(errno));
       goto err;
     }
+    tor_assert((size_t)result == chunk->len);
   });
 
   return finish_writing_to_file(file);