From: Andreas Schneider <asn@samba.org>
Date: Thu, 3 Mar 2022 14:25:14 +0000 (+0100)
Subject: s3:script: Fix shellcheck errors in test_net_registry_roundtrip.sh
X-Git-Tag: talloc-2.4.0~1375
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4edb4d979bf720b70387c6f347eab17943df933c;p=thirdparty%2Fsamba.git

s3:script: Fix shellcheck errors in test_net_registry_roundtrip.sh

source3/script/tests/test_net_registry_roundtrip.sh:51:2: error: Double
quote array expansions to avoid re-splitting elements. [SC2068]

source3/script/tests/test_net_registry_roundtrip.sh:55:16: error:
Argument mixes string and array. Use * or separate argument. [SC2145]

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
---

diff --git a/source3/script/tests/test_net_registry_roundtrip.sh b/source3/script/tests/test_net_registry_roundtrip.sh
index 6aeed0cd5a1..e1974c229e8 100755
--- a/source3/script/tests/test_net_registry_roundtrip.sh
+++ b/source3/script/tests/test_net_registry_roundtrip.sh
@@ -48,11 +48,11 @@ REGPATH="HKLM\Software\Samba"
 conf_roundtrip_step()
 {
 	echo "CMD: $*" >>$LOG
-	$@ 2>>$LOG
+	"$@" 2>>$LOG
 	RC=$?
 	echo "RC: $RC" >>$LOG
 	test "x$RC" = "x0" || {
-		echo "ERROR: $@ failed (RC=$RC)" | tee -a $LOG
+		echo "ERROR: $* failed (RC=$RC)" | tee -a $LOG
 	}
 	return $RC
 	#    echo -n .