From: James Coglan <james@neighbourhood.ie>
Date: Tue, 21 May 2024 13:39:26 +0000 (+0100)
Subject: resolved: test for dns_cache_put() with empty answer
X-Git-Tag: v257-rc1~832^2~17
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4f4c06f02d4d2e6b645bb88ffc1e031aa45812d3;p=thirdparty%2Fsystemd.git

resolved: test for dns_cache_put() with empty answer
---

diff --git a/src/resolve/test-dns-cache.c b/src/resolve/test-dns-cache.c
index c9f084d3def..d708afef7b6 100644
--- a/src/resolve/test-dns-cache.c
+++ b/src/resolve/test-dns-cache.c
@@ -104,6 +104,20 @@ TEST(dns_a_success_is_cached) {
         ASSERT_FALSE(dns_cache_is_empty(&cache));
 }
 
+TEST(dns_a_success_empty_answer_is_not_cached) {
+        _cleanup_(dns_cache_unrefp) DnsCache cache = new_cache();
+        _cleanup_(put_args_unrefp) PutArgs put_args = mk_put_args();
+
+        put_args.key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com");
+        ASSERT_NOT_NULL(put_args.key);
+        put_args.rcode = DNS_RCODE_SUCCESS;
+        put_args.answer = dns_answer_new(0);
+        ASSERT_NOT_NULL(put_args.answer);
+
+        ASSERT_OK(cache_put(&cache, &put_args));
+        ASSERT_TRUE(dns_cache_is_empty(&cache));
+}
+
 TEST(dns_a_nxdomain_is_cached) {
         _cleanup_(dns_cache_unrefp) DnsCache cache = new_cache();
         _cleanup_(put_args_unrefp) PutArgs put_args = mk_put_args();