From: Volker Lendecke <vl@samba.org>
Date: Fri, 20 Sep 2024 13:46:01 +0000 (+0200)
Subject: lsasrv: Simplify dcesrv_lsa_AddRemoveAccountRights()
X-Git-Tag: tdb-1.4.13~551
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4f727b919adcc05640d941fdbf623dc2b9fbb464;p=thirdparty%2Fsamba.git

lsasrv: Simplify dcesrv_lsa_AddRemoveAccountRights()

Use dom_sid_string_buf, no need to talloc.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source4/rpc_server/lsa/dcesrv_lsa.c b/source4/rpc_server/lsa/dcesrv_lsa.c
index 948e296eade..d497117ea77 100644
--- a/source4/rpc_server/lsa/dcesrv_lsa.c
+++ b/source4/rpc_server/lsa/dcesrv_lsa.c
@@ -3059,7 +3059,8 @@ static NTSTATUS dcesrv_lsa_AddRemoveAccountRights(struct dcesrv_call_state *dce_
 {
 	struct auth_session_info *session_info =
 		dcesrv_call_session_info(dce_call);
-	const char *sidstr, *sidndrstr;
+	struct dom_sid_buf sidbuf;
+	const char *sidndrstr = NULL;
 	struct ldb_message *msg;
 	struct ldb_message_element *el;
 	int ret;
@@ -3084,13 +3085,7 @@ static NTSTATUS dcesrv_lsa_AddRemoveAccountRights(struct dcesrv_call_state *dce_
 		return NT_STATUS_NO_MEMORY;
 	}
 
-	sidstr = dom_sid_string(msg, sid);
-	if (sidstr == NULL) {
-		TALLOC_FREE(msg);
-		return NT_STATUS_NO_MEMORY;
-	}
-
-	dnstr = talloc_asprintf(msg, "sid=%s", sidstr);
+	dnstr = talloc_asprintf(msg, "sid=%s", dom_sid_str_buf(sid, &sidbuf));
 	if (dnstr == NULL) {
 		TALLOC_FREE(msg);
 		return NT_STATUS_NO_MEMORY;