From: Martin Schwenke <martin@meltin.net>
Date: Fri, 7 Jun 2019 14:04:31 +0000 (+1000)
Subject: ctdb-protocol: Do not ignore return value of ctdb_g_lock_pull()
X-Git-Tag: samba-4.11.0rc1~47
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4f84aafa61cad21ba77b86f3341c09e0314e8b47;p=thirdparty%2Fsamba.git

ctdb-protocol: Do not ignore return value of ctdb_g_lock_pull()

clang reports:

  ctdb/protocol/protocol_types.c:5191:3: warning: Value stored to 'ret' is never read

Found by csbuild.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
---

diff --git a/ctdb/protocol/protocol_types.c b/ctdb/protocol/protocol_types.c
index 416d4843b74..8090dbddadf 100644
--- a/ctdb/protocol/protocol_types.c
+++ b/ctdb/protocol/protocol_types.c
@@ -5208,5 +5208,5 @@ done:
 
 fail:
 	talloc_free(val);
-	return ENOMEM;
+	return ret;
 }