From: Sami Kerola <kerolasa@iki.fi>
Date: Sun, 9 Aug 2020 12:58:10 +0000 (+0100)
Subject: sfdisk: do not free device name too soon [coverity scan]
X-Git-Tag: v2.36.1~22
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4fa74fd647ad5b6fa162298cfea5f600a5cd19c4;p=thirdparty%2Futil-linux.git

sfdisk: do not free device name too soon [coverity scan]

Fixes use after free error.

CID: 360798
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/disk-utils/sfdisk.c b/disk-utils/sfdisk.c
index 54d3b60e71..2e9e7cd74c 100644
--- a/disk-utils/sfdisk.c
+++ b/disk-utils/sfdisk.c
@@ -619,7 +619,6 @@ done:
 	if (f)
 		fclose(f);
 	free(buf);
-	free(devname);
 	free(typescript);
 
 	if (sf->noact)
@@ -630,6 +629,8 @@ done:
 	} else if (rc)
 		warn(_("%s: failed to move data"), devname);
 
+	free(devname);
+
 	return rc;
 }