From: Marco Crivellari Date: Tue, 4 Nov 2025 10:00:31 +0000 (+0100) Subject: drm/i915: replace use of system_wq with system_percpu_wq in the documentation X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4fb289d352e316d79fbf0e5b513e3ad17c947ff7;p=thirdparty%2Flinux.git drm/i915: replace use of system_wq with system_percpu_wq in the documentation Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. system_wq should be the per-cpu workqueue, yet in this name nothing makes that clear, so replace system_wq with system_percpu_wq. This patch continues the effort to refactor worqueue APIs, which has begun with the change introducing new workqueues: commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") The old wq (system_wq) will be kept for a few release cycles. This change only update the documentation of drm/i915. Suggested-by: Tejun Heo Signed-off-by: Marco Crivellari Reviewed-by: Krzysztof Karas Link: https://patch.msgid.link/20251104100032.61525-3-marco.crivellari@suse.com Signed-off-by: Rodrigo Vivi --- diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c index 18f912043f90d..c2365853df1b2 100644 --- a/drivers/gpu/drm/i915/i915_driver.c +++ b/drivers/gpu/drm/i915/i915_driver.c @@ -151,7 +151,7 @@ static int i915_workqueues_init(struct drm_i915_private *dev_priv) /* * The unordered i915 workqueue should be used for all work * scheduling that do not require running in order, which used - * to be scheduled on the system_wq before moving to a driver + * to be scheduled on the system_percpu_wq before moving to a driver * instance due deprecation of flush_scheduled_work(). */ dev_priv->unordered_wq = alloc_workqueue("i915-unordered", 0, 0); diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index dd380382c00e0..dafee3dcd1c52 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -249,7 +249,7 @@ struct drm_i915_private { * * This workqueue should be used for all unordered work * scheduling within i915, which used to be scheduled on the - * system_wq before moving to a driver instance due + * system_percpu_wq before moving to a driver instance due * deprecation of flush_scheduled_work(). */ struct workqueue_struct *unordered_wq;