From: JINMEI Tatuya <jinmei@isc.org>
Date: Fri, 23 Mar 2012 21:02:13 +0000 (-0700)
Subject: [master] noteed RBTree::nodeFission should preserve the current node's name.
X-Git-Tag: trac2351_base~226^2~116^2~66^2~7
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4fbbae439b8086e83e60f1708f40a83de61beaa8;p=thirdparty%2Fkea.git

[master] noteed RBTree::nodeFission should preserve the current node's name.

This will help at the phase of revisiting the design/implementation.
---

diff --git a/src/lib/datasrc/rbtree.h b/src/lib/datasrc/rbtree.h
index 1200f58126..dbf05914c0 100644
--- a/src/lib/datasrc/rbtree.h
+++ b/src/lib/datasrc/rbtree.h
@@ -1162,6 +1162,10 @@ RBTree<T>::insert(const isc::dns::Name& target_name, RBNode<T>** new_node) {
 }
 
 
+// Note: when we redesign this (still keeping the basic concept), we should
+// change this part so the newly created node will be used for the inserted
+// name (and therefore the name for the existing node doesn't change).
+// Otherwise, things like shortcut links between nodes won't work.
 template <typename T>
 void
 RBTree<T>::nodeFission(RBNode<T>& node, const isc::dns::Name& base_name) {