From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 12 Oct 2018 14:21:21 +0000 (+0200)
Subject: json: minor optimization
X-Git-Tag: v240~473^2~4
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4fcb507a909c60d8568b17fc8a9dbb8c83029c01;p=thirdparty%2Fsystemd.git

json: minor optimization

instead of comparing the magic JsonVariants one by one, let's simply
compare that they lie within a specific range.
---

diff --git a/src/basic/json-internal.h b/src/basic/json-internal.h
index 6d195eb672f..98e53ede10c 100644
--- a/src/basic/json-internal.h
+++ b/src/basic/json-internal.h
@@ -35,6 +35,7 @@ assert_cc(sizeof(JsonValue) == 16U);
 #define JSON_VARIANT_MAGIC_EMPTY_STRING ((JsonVariant*) 7)
 #define JSON_VARIANT_MAGIC_EMPTY_ARRAY ((JsonVariant*) 8)
 #define JSON_VARIANT_MAGIC_EMPTY_OBJECT ((JsonVariant*) 9)
+#define _JSON_VARIANT_MAGIC_MAX ((JsonVariant*) 10)
 
 enum { /* JSON tokens */
         JSON_TOKEN_END,
diff --git a/src/basic/json.c b/src/basic/json.c
index 72e8e115baf..f3db01eb993 100644
--- a/src/basic/json.c
+++ b/src/basic/json.c
@@ -140,15 +140,10 @@ static bool json_source_equal(JsonSource *a, JsonSource *b) {
 DEFINE_TRIVIAL_CLEANUP_FUNC(JsonSource*, json_source_unref);
 
 static bool json_variant_is_magic(const JsonVariant *v) {
-        return v == JSON_VARIANT_MAGIC_TRUE ||
-                v == JSON_VARIANT_MAGIC_FALSE ||
-                v == JSON_VARIANT_MAGIC_NULL ||
-                v == JSON_VARIANT_MAGIC_ZERO_INTEGER ||
-                v == JSON_VARIANT_MAGIC_ZERO_UNSIGNED ||
-                v == JSON_VARIANT_MAGIC_ZERO_REAL ||
-                v == JSON_VARIANT_MAGIC_EMPTY_STRING ||
-                v == JSON_VARIANT_MAGIC_EMPTY_ARRAY ||
-                v == JSON_VARIANT_MAGIC_EMPTY_OBJECT;
+        if (!v)
+                return false;
+
+        return v < _JSON_VARIANT_MAGIC_MAX;
 }
 
 static JsonVariant *json_variant_dereference(JsonVariant *v) {