From: Ondřej Surý Date: Wed, 15 Apr 2020 10:50:28 +0000 (+0200) Subject: Fix the discrepancy between cfg_pluginlist_foreach declaration and definition X-Git-Tag: v9.17.2~146^2~3 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=4ffe7255853b8332bb585d96a25efb9e56bdcfa7;p=thirdparty%2Fbind9.git Fix the discrepancy between cfg_pluginlist_foreach declaration and definition There was a missing indirection for the pluginlist_cb_t *callback in the declaration of the cfg_pluginlist_foreach function. Reported by MSVC as: lib\isccfg\parser.c(4057): warning C4028: formal parameter 4 different from declaration --- diff --git a/lib/isccfg/include/isccfg/cfg.h b/lib/isccfg/include/isccfg/cfg.h index 3123a9b39fe..eda5b46a69a 100644 --- a/lib/isccfg/include/isccfg/cfg.h +++ b/lib/isccfg/include/isccfg/cfg.h @@ -597,7 +597,7 @@ typedef isc_result_t(pluginlist_cb_t)(const cfg_obj_t *config, isc_result_t cfg_pluginlist_foreach(const cfg_obj_t *config, const cfg_obj_t *list, - isc_log_t *lctx, pluginlist_cb_t callback, + isc_log_t *lctx, pluginlist_cb_t *callback, void *callback_data); /*%< * For every "plugin" stanza present in 'list' (which in turn is a part of