From: msizanoen1 <msizanoen@qtmlabs.xyz>
Date: Tue, 7 Feb 2023 13:17:21 +0000 (+0700)
Subject: unit: always return 1 in log_kill
X-Git-Tag: v253-rc3~28
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=500cd2e83b8246fbf20d99db898039cfba746223;p=thirdparty%2Fsystemd.git

unit: always return 1 in log_kill

This ensures that cg_kill_items returns the correct value to let the
manager know that a process was killed.
---

diff --git a/src/core/unit.c b/src/core/unit.c
index 16624690124..499e9b40eda 100644
--- a/src/core/unit.c
+++ b/src/core/unit.c
@@ -4500,7 +4500,9 @@ static int log_kill(pid_t pid, int sig, void *userdata) {
         /* Don't log about processes marked with brackets, under the assumption that these are temporary processes
            only, like for example systemd's own PAM stub process. */
         if (comm && comm[0] == '(')
-                return 0;
+                /* Although we didn't log anything, as this callback is used in unit_kill_context we must return 1
+                 * here to let the manager know that a process was killed. */
+                return 1;
 
         log_unit_notice(userdata,
                         "Killing process " PID_FMT " (%s) with signal SIG%s.",