From: Jo Sutton Date: Fri, 19 Apr 2024 00:57:50 +0000 (+1200) Subject: tests/krb5: Skip loop iteration if attribute has no values X-Git-Tag: tdb-1.4.11~1072 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=502070cd9a5eb7eef0f98d73b967f1d63b9403f0;p=thirdparty%2Fsamba.git tests/krb5: Skip loop iteration if attribute has no values Signed-off-by: Jo Sutton Reviewed-by: Andrew Bartlett --- diff --git a/python/samba/tests/krb5/kdc_base_test.py b/python/samba/tests/krb5/kdc_base_test.py index 11ad210dc41..a2525a4299c 100644 --- a/python/samba/tests/krb5/kdc_base_test.py +++ b/python/samba/tests/krb5/kdc_base_test.py @@ -1161,10 +1161,11 @@ class KDCBaseTest(TestCaseInTempDir, RawKerberosTest): keys = {} for attr in attributes: + if not attr.value_ctr.num_values: + continue + if attr.attid == drsuapi.DRSUAPI_ATTID_supplementalCredentials: net_ctx.replicate_decrypt(bind, attr, rid) - if attr.value_ctr.num_values == 0: - continue attr_val = attr.value_ctr.values[0].blob spl = ndr_unpack(drsblobs.supplementalCredentialsBlob, @@ -1182,9 +1183,8 @@ class KDCBaseTest(TestCaseInTempDir, RawKerberosTest): keys[keytype] = key.value.hex() elif attr.attid == drsuapi.DRSUAPI_ATTID_unicodePwd: net_ctx.replicate_decrypt(bind, attr, rid) - if attr.value_ctr.num_values > 0: - pwd = attr.value_ctr.values[0].blob - keys[kcrypto.Enctype.RC4] = pwd.hex() + pwd = attr.value_ctr.values[0].blob + keys[kcrypto.Enctype.RC4] = pwd.hex() if expected_etypes is None: expected_etypes = self.get_default_enctypes(creds)