From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 15 Jul 2022 09:02:40 +0000 (+0200)
Subject: cgroups-agent: connect stdin/stdout/stderr to /dev/null
X-Git-Tag: v252-rc1~635
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=50492ce81589773df2d82b4fc8047778e86c6edf;p=thirdparty%2Fsystemd.git

cgroups-agent: connect stdin/stdout/stderr to /dev/null

Inspired by https://github.com/systemd/systemd/pull/24024 this is
another user mode helper, where this might be an issue. hence let's
rather be safe than sorry, and also connect stdin/stdout/stderr
explicitly with /dev/null.
---

diff --git a/src/cgroups-agent/cgroups-agent.c b/src/cgroups-agent/cgroups-agent.c
index 071cba30996..91267362351 100644
--- a/src/cgroups-agent/cgroups-agent.c
+++ b/src/cgroups-agent/cgroups-agent.c
@@ -16,6 +16,13 @@ int main(int argc, char *argv[]) {
         _cleanup_close_ int fd = -1;
         ssize_t n;
         size_t l;
+        int r;
+
+        r = rearrange_stdio(-1, -1, -1);
+        if (r < 0) {
+                log_error_errno(r, "Failed to connect stdin/stdout/stderr with /dev/null: %m");
+                return EXIT_FAILURE;
+        }
 
         if (argc != 2) {
                 log_error("Incorrect number of arguments.");