From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Mon, 13 Oct 2025 16:16:22 +0000 (+0200)
Subject: BUG/MINOR: quic: check applet_putchk() for 'show quic' first line
X-Git-Tag: v3.3-dev10~12
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5067a15870ca27bb6519f9076b8c8a7c7db8ab14;p=thirdparty%2Fhaproxy.git

BUG/MINOR: quic: check applet_putchk() for 'show quic' first line

Ensure applet_putchk() return value is checked when outputing via the
CLI 'show quic' header line.

This is only to align with other usages of the same function, as trash
output buffer should always be large enough for it. As such, the command
is simply aborted if this is not the case.

This should fix coverity report from github issue #3139.

This could be backported up to 2.8.
---

diff --git a/src/quic_cli.c b/src/quic_cli.c
index 1f22f8d05..2173d22d8 100644
--- a/src/quic_cli.c
+++ b/src/quic_cli.c
@@ -460,7 +460,10 @@ static int cli_io_handler_dump_quic(struct appctx *appctx)
 				      "in_flight infl_p lost_p         "
 				      "Local Address           Foreign Address      "
 				      "local & remote CIDs\n");
-			applet_putchk(appctx, &trash);
+			if (applet_putchk(appctx, &trash) == -1) {
+				/* Trash buf too short without any data emitted yet, should never happen. */
+				goto done;
+			}
 		}
 	}