From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 23 Dec 2019 15:35:44 +0000 (+0100)
Subject: core: no need to eat up error
X-Git-Tag: v245-rc1~120^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5085ef0d711f1faaacddaf5519daeb150794ea99;p=thirdparty%2Fsystemd.git

core: no need to eat up error

This is a method call reply. We might as well propagate the error. The
worst that happens is that sd-bus logs about it.
---

diff --git a/src/core/unit.c b/src/core/unit.c
index be92d975002..5cf16c6a795 100644
--- a/src/core/unit.c
+++ b/src/core/unit.c
@@ -3227,10 +3227,8 @@ static int get_name_owner_handler(sd_bus_message *message, void *userdata, sd_bu
         }
 
         r = sd_bus_message_read(message, "s", &new_owner);
-        if (r < 0) {
-                bus_log_parse_error(r);
-                return 0;
-        }
+        if (r < 0)
+                return bus_log_parse_error(r);
 
         if (UNIT_VTABLE(u)->bus_name_owner_change)
                 UNIT_VTABLE(u)->bus_name_owner_change(u, NULL, new_owner);