From: Noel Power <noel.power@suse.com>
Date: Wed, 3 Jul 2019 14:56:55 +0000 (+0000)
Subject: s4/dsdb/schema: Fix 'Value stored to 'ret' is never read'
X-Git-Tag: samba-4.11.0rc1~21
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=50a22849ce11aebead43e39ea42541afdd987408;p=thirdparty%2Fsamba.git

s4/dsdb/schema: Fix 'Value stored to 'ret' is never read'

Fixes:

source4/dsdb/schema/schema_set.c:274:3: warning: Value stored to 'ret' is never read <--[clang]
                ret = LDB_SUCCESS;
                ^     ~~~~~~~~~~~
source4/dsdb/schema/schema_set.c:327:3: warning: Value stored to 'ret' is never read <--[clang]
                ret = LDB_SUCCESS;
                ^     ~~~~~~~~~~~

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source4/dsdb/schema/schema_set.c b/source4/dsdb/schema/schema_set.c
index 258cbb81f25..b316686fd03 100644
--- a/source4/dsdb/schema/schema_set.c
+++ b/source4/dsdb/schema/schema_set.c
@@ -271,7 +271,6 @@ int dsdb_schema_set_indices_and_attributes(struct ldb_context *ldb,
 		}
 		ret = ldb_add(ldb, msg);
 	} else {
-		ret = LDB_SUCCESS;
 		/* Annoyingly added to our search results */
 		ldb_msg_remove_attr(res->msgs[0], "distinguishedName");
 
@@ -324,7 +323,6 @@ int dsdb_schema_set_indices_and_attributes(struct ldb_context *ldb,
 		}
 		ret = ldb_add(ldb, msg_idx);
 	} else {
-		ret = LDB_SUCCESS;
 		/* Annoyingly added to our search results */
 		ldb_msg_remove_attr(res_idx->msgs[0], "distinguishedName");