From: Zachary Ware <zachary.ware@gmail.com>
Date: Thu, 28 Nov 2013 05:56:04 +0000 (-0600)
Subject: Issue #19595: Re-enable a long-disabled test in test_winsound
X-Git-Tag: v3.4.0b2~447
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=50a5dad608eb4e582a30726c2214b6578d6e11db;p=thirdparty%2FPython%2Fcpython.git

Issue #19595: Re-enable a long-disabled test in test_winsound
---

diff --git a/Lib/test/test_winsound.py b/Lib/test/test_winsound.py
index 61d864a64857..d8a617e64fbd 100644
--- a/Lib/test/test_winsound.py
+++ b/Lib/test/test_winsound.py
@@ -158,18 +158,14 @@ class PlaySoundTest(unittest.TestCase):
             )
 
     def test_alias_fallback(self):
-        # This test can't be expected to work on all systems.  The MS
-        # PlaySound() docs say:
-        #
-        #     If it cannot find the specified sound, PlaySound uses the
-        #     default system event sound entry instead.  If the function
-        #     can find neither the system default entry nor the default
-        #     sound, it makes no sound and returns FALSE.
-        #
-        # It's known to return FALSE on some real systems.
-
-        # winsound.PlaySound('!"$%&/(#+*', winsound.SND_ALIAS)
-        return
+        if _have_soundcard():
+            winsound.PlaySound('!"$%&/(#+*', winsound.SND_ALIAS)
+        else:
+            self.assertRaises(
+                RuntimeError,
+                winsound.PlaySound,
+                '!"$%&/(#+*', winsound.SND_ALIAS
+            )
 
     def test_alias_nofallback(self):
         if _have_soundcard():
diff --git a/Misc/NEWS b/Misc/NEWS
index 4ed79503987d..3c82e1ab218e 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -31,6 +31,8 @@ Library
 Tests
 -----
 
+- Issue #19595: Re-enabled a long-disabled test in test_winsound.
+
 - Issue #19588: Fixed tests in test_random that were silently skipped most
   of the time.  Patch by Julian Gindi.