From: Raphael Gallais-Pou Date: Sun, 12 Apr 2026 19:07:58 +0000 (+0200) Subject: video: stm32: dsi: fix unchecked return values X-Git-Tag: v2026.07-rc2~35^2~14 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=51678d9479ed117619d2675e4023911fabbeb6c4;p=thirdparty%2Fu-boot.git video: stm32: dsi: fix unchecked return values Fix the following errors yielded by Coverity Scan: CID 644836: Error handling issues (CHECKED_RETURN) Calling device_chld_unbind without checking return value (as is done elsewhere 6 out of 7 times) CID 644834: Error handling issues (CHECKED_RETURN) Calling device_chld_remove without checking return value (as is done elsewhere 4 out of 5 times). Link: https://lore.kernel.org/r/20260309212331.GF1388590@bill-the-cat/ Fixes: a6d047c0a86b ("video: stm32: remove all child of DSI bridge when its probe failed") Signed-off-by: Raphael Gallais-Pou Reviewed-by: Patrice Chotard --- diff --git a/drivers/video/stm32/stm32_dsi.c b/drivers/video/stm32/stm32_dsi.c index 65a91f5cff7..5c4d8d2aab5 100644 --- a/drivers/video/stm32/stm32_dsi.c +++ b/drivers/video/stm32/stm32_dsi.c @@ -493,8 +493,11 @@ static int stm32_dsi_probe(struct udevice *dev) priv->hw_version != HWVER_131) { dev_err(dev, "DSI version 0x%x not supported\n", priv->hw_version); dev_dbg(dev, "remove and unbind all DSI child\n"); - device_chld_remove(dev, NULL, DM_REMOVE_NORMAL); - device_chld_unbind(dev, NULL); + ret = device_chld_remove(dev, NULL, DM_REMOVE_NORMAL); + if (!ret) + ret = device_chld_unbind(dev, NULL); + if (ret) + dev_err(dev, "Unbinding from %s failed %d\n", dev->name, ret); ret = -ENODEV; goto err_clk; }