From: Alan T. DeKok <aland@freeradius.org>
Date: Fri, 3 Nov 2017 13:06:50 +0000 (-0400)
Subject: check DHCP-Message-Type
X-Git-Tag: release_3_0_16~74
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=516a3b6fe660f40fb4a74f119641fb324461ca8c;p=thirdparty%2Ffreeradius-server.git

check DHCP-Message-Type
---

diff --git a/src/modules/proto_dhcp/dhcp.c b/src/modules/proto_dhcp/dhcp.c
index 5fd922d037c..c8b34a5424c 100644
--- a/src/modules/proto_dhcp/dhcp.c
+++ b/src/modules/proto_dhcp/dhcp.c
@@ -1106,10 +1106,10 @@ int fr_dhcp_decode(RADIUS_PACKET *packet)
 	memcpy(&giaddr, packet->data + 24, sizeof(giaddr));
 	if (giaddr == htonl(INADDR_ANY)) {
 		/*
-		 *	DHCP Opcode is request
+		 *	DHCP-Message-Type is request
 		 */
-		vp = fr_pair_find_by_num(head, 256, DHCP_MAGIC_VENDOR, TAG_ANY);
-		if (vp && vp->vp_integer == 3) {
+		vp = fr_pair_find_by_num(head, 53, DHCP_MAGIC_VENDOR, TAG_ANY);
+		if (vp && vp->vp_byte == 3) {
 			/*
 			 *	Vendor is "MSFT 98"
 			 */