From: Michael Adam <obnox@samba.org>
Date: Wed, 16 Apr 2008 20:42:49 +0000 (+0200)
Subject: libsmbconf: fix segfault in listing share names / config.
X-Git-Tag: samba-3.3.0pre1~2641^2~81
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=518f4d4e6662138a2e71acc2296acedefc7c739a;p=thirdparty%2Fsamba.git

libsmbconf: fix segfault in listing share names / config.

Discovered by Günther while giving a talk. - Sorry Günther!

Michael
---

diff --git a/source/lib/smbconf/smbconf_reg.c b/source/lib/smbconf/smbconf_reg.c
index 39b05f7016e..930999cc3fc 100644
--- a/source/lib/smbconf/smbconf_reg.c
+++ b/source/lib/smbconf/smbconf_reg.c
@@ -784,7 +784,7 @@ static WERROR smbconf_reg_get_share_names(struct smbconf_ctx *ctx,
 	/* make sure "global" is always listed first */
 	if (smbconf_share_exists(ctx, GLOBAL_NAME)) {
 		werr = smbconf_add_string_to_array(tmp_ctx, &tmp_share_names,
-						   1, GLOBAL_NAME);
+						   added_count, GLOBAL_NAME);
 		if (!W_ERROR_IS_OK(werr)) {
 			goto done;
 		}