From: Volker Lendecke <vl@samba.org>
Date: Tue, 19 Nov 2019 13:17:38 +0000 (+0100)
Subject: librpc: Fix CID 1455913 Use after free
X-Git-Tag: ldb-2.1.0~678
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=51f16ec578987506a2ea07401b287b731c08c3a1;p=thirdparty%2Fsamba.git

librpc: Fix CID 1455913 Use after free

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/librpc/rpc/dcerpc_util.c b/librpc/rpc/dcerpc_util.c
index 1fb3fa72075..32df534d5d9 100644
--- a/librpc/rpc/dcerpc_util.c
+++ b/librpc/rpc/dcerpc_util.c
@@ -1434,10 +1434,11 @@ void dcerpc_log_packet(const char *lockdir,
 		}
 
 		saved = file_save(name, pkt->data, pkt->length);
-		free(name);
 		if (saved) {
 			DBG_DEBUG("Logged rpc packet to %s\n", name);
+			free(name);
 			break;
 		}
+		free(name);
 	}
 }