From: Robin Hack <hack.robin@gmail.com>
Date: Tue, 26 Apr 2016 13:17:51 +0000 (+0200)
Subject: dcesrv_backupkey_heimdal: Fix CID 1321647 - Unchecked return value
X-Git-Tag: talloc-2.1.7~122
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=51f221c86eb7004f7a45c9cd03aa889e94a8dbc6;p=thirdparty%2Fsamba.git

dcesrv_backupkey_heimdal: Fix CID 1321647 - Unchecked return value

Unchecked return value of gnutls_global_init().

Signed-off-by: Robin Hack <hack.robin@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source4/rpc_server/backupkey/dcesrv_backupkey_heimdal.c b/source4/rpc_server/backupkey/dcesrv_backupkey_heimdal.c
index ac12c648dae..a9bd57fd51e 100644
--- a/source4/rpc_server/backupkey/dcesrv_backupkey_heimdal.c
+++ b/source4/rpc_server/backupkey/dcesrv_backupkey_heimdal.c
@@ -829,7 +829,11 @@ static WERROR create_heimdal_rsa_key(TALLOC_CTX *ctx, hx509_context *hctx,
 
 	*rsa = NULL;
 
-	gnutls_global_init();
+	ret = gnutls_global_init();
+	if (ret != GNUTLS_E_SUCCESS) {
+		DBG_ERR("TLS error: %s\n", gnutls_strerror(ret));
+		return WERR_INTERNAL_ERROR;
+	}
 #if defined(HAVE_GCRYPT_H) && !defined(HAVE_GNUTLS3)
 	DEBUG(3,("Enabling QUICK mode in gcrypt\n"));
 	gcry_control(GCRYCTL_ENABLE_QUICK_RANDOM, 0);