From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 11 Jul 2024 12:32:09 +0000 (+0200)
Subject: import-creds: when we hit ENOENT on SMBIOS 11 do not even debug log
X-Git-Tag: v257-rc1~921
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5202ee42d5da0ae3a6655d2bc959a19d8c347e9d;p=thirdparty%2Fsystemd.git

import-creds: when we hit ENOENT on SMBIOS 11 do not even debug log

We'll *always* hit ENEOENT when iterating through SMBIOS type #11
fields, on the last one. it's very confusing to debug log about that,
let's just not do it.
---

diff --git a/src/core/import-creds.c b/src/core/import-creds.c
index 4008ea43e9e..8cc4e19ab6d 100644
--- a/src/core/import-creds.c
+++ b/src/core/import-creds.c
@@ -583,9 +583,10 @@ static int import_credentials_smbios(ImportCredentialContext *c) {
                 size_t size;
 
                 r = read_smbios11_field(i, CREDENTIALS_TOTAL_SIZE_MAX, &data, &size);
+                if (r == -ENOENT) /* Once we reach ENOENT there are no more DMI Type 11 fields around. */
+                        break;
                 if (r < 0) {
-                        /* Once we reach ENOENT there are no more DMI Type 11 fields around. */
-                        log_full_errno(r == -ENOENT ? LOG_DEBUG : LOG_WARNING, r, "Failed to read SMBIOS type #11 object %u, ignoring: %m", i);
+                        log_warning_errno(r, "Failed to read SMBIOS type #11 object %u, ignoring: %m", i);
                         break;
                 }