From: Antoine Pitrou <solipsis@pitrou.net>
Date: Tue, 21 Sep 2010 16:08:27 +0000 (+0000)
Subject: Issue #2643: msync() is not called anymore when deallocating an open mmap
X-Git-Tag: v3.2a3~179
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=52d42503d5f7e763264b03f12785c46a467c196b;p=thirdparty%2FPython%2Fcpython.git

Issue #2643: msync() is not called anymore when deallocating an open mmap
object, only munmap().
---

diff --git a/Misc/NEWS b/Misc/NEWS
index 139ab0188fe6..cdd9ef7060c4 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -58,6 +58,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #2643: msync() is not called anymore when deallocating an open mmap
+  object, only munmap().
+
 - logging: Changed LoggerAdapter implementation internally, to make it
   easier to subclass in a useful way.
 
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
index 8c5c8ac80a00..3413f17ebd3c 100644
--- a/Modules/mmapmodule.c
+++ b/Modules/mmapmodule.c
@@ -125,7 +125,6 @@ mmap_object_dealloc(mmap_object *m_obj)
     if (m_obj->fd >= 0)
         (void) close(m_obj->fd);
     if (m_obj->data!=NULL) {
-        msync(m_obj->data, m_obj->size, MS_SYNC);
         munmap(m_obj->data, m_obj->size);
     }
 #endif /* UNIX */