From: William Lallemand <wlallemand@haproxy.com>
Date: Mon, 23 Mar 2026 12:57:48 +0000 (+0100)
Subject: BUG/MINOR: acme: NULL check on my_strndup()
X-Git-Tag: v3.4-dev8~115
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=52d8ee85e7fca21405cb30d8d346e7a130df3200;p=thirdparty%2Fhaproxy.git

BUG/MINOR: acme: NULL check on my_strndup()

Add a NULL check on my_strndup().

Must be backported to 3.2 and later.
---

diff --git a/src/acme.c b/src/acme.c
index aa0a6c51a..943ca22ab 100644
--- a/src/acme.c
+++ b/src/acme.c
@@ -2558,7 +2558,8 @@ X509_REQ *acme_x509_req(EVP_PKEY *pkey, char **san)
 	for (i = 0; san[i]; i++) {
 		chunk_appendf(san_trash, "%sDNS:%s", i ? "," : "", san[i]);
 	}
-	str_san = my_strndup(san_trash->area, san_trash->data);
+	if ((str_san = my_strndup(san_trash->area, san_trash->data)) == NULL)
+		goto error;
 
 	if ((ext_san = X509V3_EXT_conf_nid(NULL, NULL, NID_subject_alt_name, str_san)) == NULL)
 		goto error;