From: Simon McVittie <smcv@collabora.com>
Date: Wed, 11 Jul 2018 15:15:38 +0000 (+0100)
Subject: loopback: Don't free credentials borrowed from the connection
X-Git-Tag: dbus-1.13.6~18
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=532d6d7caeb404d14ebbe654f0941e2e5d502a88;p=thirdparty%2Fdbus.git

loopback: Don't free credentials borrowed from the connection

We currently get away with this because the connection isn't fully
freed before we exit, but the connection is meant to own the result
of _dbus_connection_get_credentials() (it's "(transfer none)" in
GLib terminology).

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=107194
---

diff --git a/test/loopback.c b/test/loopback.c
index 5ab8be9c2..23fe4c8bf 100644
--- a/test/loopback.c
+++ b/test/loopback.c
@@ -302,7 +302,6 @@ test_connect (Fixture *f,
                   _dbus_string_get_const_data (&cred_string));
   g_assert_cmpstr (_dbus_string_get_const_data (&cred_string), !=, NULL);
   _dbus_string_free (&cred_string);
-  _dbus_clear_credentials (&creds);
 
   dbus_free (address);
 }