From: Volker Lendecke <vl@samba.org>
Date: Wed, 15 Jul 2026 10:06:40 +0000 (+0200)
Subject: ldb: ldb_dn_get_extended_linearized()
X-Git-Tag: tevent-0.17.2~7
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5365e1c777364abaca32ff2cfa524dbb62e56ff7;p=thirdparty%2Fsamba.git

ldb: ldb_dn_get_extended_linearized()

Use talloc_asprintf_addsep()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/lib/ldb/common/ldb_dn.c b/lib/ldb/common/ldb_dn.c
index b29dc0f4de7..4731153f699 100644
--- a/lib/ldb/common/ldb_dn.c
+++ b/lib/ldb/common/ldb_dn.c
@@ -853,6 +853,8 @@ char *ldb_dn_get_extended_linearized(TALLOC_CTX *mem_ctx, struct ldb_dn *dn, int
 		return NULL;
 	}
 
+	p = talloc_strdup(mem_ctx, "");
+
 	for (i = 0; i < dn->ext_comp_num; i++) {
 		const struct ldb_dn_extended_syntax *ext_syntax;
 		const char *name = dn->ext_components[i].name;
@@ -879,17 +881,8 @@ char *ldb_dn_get_extended_linearized(TALLOC_CTX *mem_ctx, struct ldb_dn *dn, int
 			return NULL;
 		}
 
-		if (i == 0) {
-			p = talloc_asprintf(mem_ctx, "<%s=%.*s>",
-					    name,
-					    (int)val.length,
-					    val.data);
-		} else {
-			talloc_asprintf_addbuf(&p, ";<%s=%.*s>",
-					       name,
-					       (int)val.length,
-					       val.data);
-		}
+		talloc_asprintf_addsep(
+			&p, ";", "<%s=%.*s>", name, (int)val.length, val.data);
 
 		talloc_free(val.data);
 	}